[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Patch to add a 7-day (up-to) forecast to the NOAA
From:       "Shawn Starr" <shawn.starr () rogers ! com>
Date:       2009-09-17 16:59:39
Message-ID: 20090917165939.21240.73065 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1584/#review2391
-----------------------------------------------------------

Ship it!


This looks good now. Please commit

- Shawn


On 2009-09-14 23:24:56, Amos Kariuki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1584/
> -----------------------------------------------------------
> 
> (Updated 2009-09-14 23:24:56)
> 
> 
> Review request for Plasma and Shawn Starr.
> 
> 
> Summary
> -------
> 
> The patch uses the REST API provided by NOAA at \
> <http://www.weather.gov/forecasts/xml/rest.php> to obtain the forecast for the \
> location coordinates returned by the observation data.  It requests the 7-day \
> forecast but only displays the days for which data is available (usually 5-7 days). \
> The weather icon descriptions unfortunately don't match those used by the normal \
> observation feed, and are defined at \
> <http://www.weather.gov/forecasts/xml/DWMLgen/schema/parameters.xsd> ; we however \
> use a similar heuristic algorithm (keyword search)) to find the best match for the \
> returned weather conditions. 
> This patch also enables the normal condition icon which was being mistakenly being \
> unset. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/data/noaa_i18n.dat \
> 1016572  trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/ion_noaa.h \
> 1016575  trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/ion_noaa.cpp \
> 1021754  
> Diff: http://reviewboard.kde.org/r/1584/diff
> 
> 
> Testing
> -------
> 
> Verified the NOAA forecast was displayed in the Weather Forecast applet for a few \
> locations. 
> 
> Thanks,
> 
> Amos
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]