[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: big revamp of Device Notifier
From:       "Giulio Camuffo" <giuliocamuffo () gmail ! com>
Date:       2009-09-11 21:32:18
Message-ID: 20090911213218.19385.55489 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1370/
-----------------------------------------------------------

(Updated 2009-09-11 21:32:17.946758)


Review request for Plasma.


Changes
-------

-updated the patch to the latest svn
-using Plasma::Applet::showMessage instead of KMessageBox
-removed hidePopupAfter(int)
-change icon on the insertion of a new device even if the popup is shown
-many others style issues and oversights fixed


Summary
-------

This is a patch that modifies quite heavily the behaviour of the Device Notifier.
It comes from here: http://kde-look.org/content/show.php/Device+Manager?content=106051
 It can show the not removable devices too, it can mount them automatically or with a \
click, since the "eject" button is a "mount" button when the volume is umounted. So \
that guy on the dot will be ok. It can hide some items in the same way as Dolphin's \
places (hide item/ show all). Finally, it shows the various opening actions under the \
device instead of calling that xp-ish window.


Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h 1022457 \
  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp \
1022457   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h \
1022457   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp \
1022457   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt \
1022457   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui \
PRE-CREATION   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h \
1022457   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp \
1022457   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h \
1022457   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp \
1022457 

Diff: http://reviewboard.kde.org/r/1370/diff


Testing
-------

I'm using it every day since I released 0.1 on Kde-look. I tried all the options on \
my pc and they work. Some people on kde-look posted some comments about some \
problems, but it seems to me they are very particular cases, so in my opinion it is \
quite stable to go in trunk, but anyway review it! :)


Screenshots
-----------

screen
  http://reviewboard.kde.org/r/1370/s/183/


Thanks,

Giulio

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]