[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Add image effects to plasma image wallpaper plugin
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2009-09-06 9:17:57
Message-ID: 20090906091757.25755.84608 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1527/#review2251
-----------------------------------------------------------


How is the performance impact on initial Plasma startup? I fear that this could slow \
down KDE startup time as the effect is done on CPU. That brings me directly to the \
next point: such effects should be done on the GPU with a shader either by just \
manipulating the image and paint the resulting image as done in your patch or by \
rendering complete Plasma scene with OpenGL and attaching the shader dynamically. The \
second one would be optimal for things like grayscale as it is basically "free" and \
doesn't add any overhead. And of course the effect wouldn't be limited to \
image/slideshow but available for all wallpaper plugins.

Oh and why qimageblitz? IIRC Qt 4.6 will ship some effects (assuming that KDE 4.4 \
will require Qt 4.6).

- Martin


On 2009-09-05 22:52:05, Shafqat Bhuiyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1527/
> -----------------------------------------------------------
> 
> (Updated 2009-09-05 22:52:05)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> This patch adds an option to have effects applied to images in the image wallpaper. \
>                 The current effects are:
> - None
> - Grayscale
> - Colorize
> - Blur
> - Contrast
> - Desaturate
> - Lighten
> - Darken
> - Invert
> - Oil Paint
> 
> The effects can be applied in both single image and slide show modes. There is only \
> a slight performance loss in between changing images. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/workspace/plasma/wallpapers/image/CMakeLists.txt 1020267 
> trunk/KDE/kdebase/workspace/plasma/wallpapers/image/image.h 1020267 
> trunk/KDE/kdebase/workspace/plasma/wallpapers/image/image.cpp 1020267 
> trunk/KDE/kdebase/workspace/plasma/wallpapers/image/imageconfig.ui 1020267 
> trunk/KDE/kdebase/workspace/plasma/wallpapers/image/imageeffects.h PRE-CREATION 
> trunk/KDE/kdebase/workspace/plasma/wallpapers/image/imageeffects.cpp PRE-CREATION 
> trunk/KDE/kdebase/workspace/plasma/wallpapers/image/slideshowconfig.ui 1020267 
> 
> Diff: http://reviewboard.kde.org/r/1527/diff
> 
> 
> Testing
> -------
> 
> Tested in trunk.
> 
> 
> Screenshots
> -----------
> 
> Configuration Dialog
> http://reviewboard.kde.org/r/1527/s/200/
> 
> 
> Thanks,
> 
> Shafqat
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]