From kde-panel-devel  Mon Aug 31 16:11:28 2009
From: "Marco Martin" <notmart () gmail ! com>
Date: Mon, 31 Aug 2009 16:11:28 +0000
To: kde-panel-devel
Subject: Re: Review Request: Keyboard navigation support for Tasks applet
Message-Id: <20090831161128.6240.69350 () localhost>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=125173510517017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1482/#review2230
-----------------------------------------------------------

Ship it!


seems good

- Marco


On 2009-08-31 16:03:46, Michal Dutkiewicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1482/
> -----------------------------------------------------------
> 
> (Updated 2009-08-31 16:03:46)
> 
> 
> Review request for Plasma, Aaron Seigo and Marco Martin.
> 
> 
> Summary
> -------
> 
> This patch adds support for [Shift + ] Tab navigation (and Enter / Return to activate item) in Tasks plasmoid.
> In order to work it needs fixing of panel focusing issue (as discussed on mailing list), I could apply mine method for temporary use if needed.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.h 1017535 
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.cpp 1017535 
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.h 1017535 
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp 1017535 
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.h 1017535 
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.cpp 1017535 
> 
> Diff: http://reviewboard.kde.org/r/1482/diff
> 
> 
> Testing
> -------
> 
> Tested in plasmoidviwer and works (groups may need additional testing).
> 
> 
> Thanks,
> 
> Michal
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel