[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Custom combo boxes for Plasma::ComboBox
From: "Aaron Seigo" <aseigo () kde ! org>
Date: 2009-08-30 19:40:44
Message-ID: 20090830194044.14725.69653 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1094/#review2193
-----------------------------------------------------------
Ship it!
i'm fine with this going in; line edit and text edits too, i think. but spinbox? i \
don't think it's that common to subclass it ...?
- Aaron
On 2009-08-30 16:39:32, Michal Dutkiewicz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1094/
> -----------------------------------------------------------
>
> (Updated 2009-08-30 16:39:32)
>
>
> Review request for Plasma, Aaron Seigo and Marco Martin.
>
>
> Summary
> -------
>
> This patch adds possibility to use custom combo box widgets (sub classed from \
> KComboBox) instead of plain KComboBox.
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/plasma/widgets/combobox.h 1016281
> /trunk/KDE/kdelibs/plasma/widgets/combobox.cpp 1016281
>
> Diff: http://reviewboard.kde.org/r/1094/diff
>
>
> Testing
> -------
>
> Compiles and should work, but not tested.
>
>
> Screenshots
> -----------
>
> Plasma themed KHistoryComboBox in Run Command applet
> http://reviewboard.kde.org/r/1094/s/151/
>
>
> Thanks,
>
> Michal
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic