[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Center tool tips in Plasma
From:       "Michal Dutkiewicz" <emdeck () gmail ! com>
Date:       2009-08-29 8:56:02
Message-ID: 20090829085602.15266.20626 () localhost
[Download RAW message or body]



> On 2009-08-28 21:42:20, Aaron Seigo wrote:
> > /trunk/KDE/kdelibs/plasma/corona.cpp, line 511
> > <http://reviewboard.kde.org/r/1428/diff/1/?file=10799#file10799line511>
> > 
> > i thought we were going to avoid the bool and instead use Qt::Alignment?

So only one public method with optional Alignment flag (by default alignment would be \
as now, usually to left edge etc.) and for now accepting only Qt::AlignCenter?


- Michal


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1428/#review2173
-----------------------------------------------------------


On 2009-08-28 20:26:02, Michal Dutkiewicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1428/
> -----------------------------------------------------------
> 
> (Updated 2009-08-28 20:26:02)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> This patch aims to provide centered tool tips for Plasma (aligned to edge in some \
> cases looks bad). 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/plasma/corona.h 1016281 
> /trunk/KDE/kdelibs/plasma/corona.cpp 1016281 
> /trunk/KDE/kdelibs/plasma/tooltipmanager.cpp 1016281 
> 
> Diff: http://reviewboard.kde.org/r/1428/diff
> 
> 
> Testing
> -------
> 
> Tested only if compile, not tested if works (can't compile full trunk now... \
> problems with Akonadi), relies on commented out code to center popups. 
> 
> Thanks,
> 
> Michal
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]