[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Patch to add free space indicator into device
From:       Alessandro Diaferia <alediaferia () gmail ! com>
Date:       2009-08-21 10:07:05
Message-ID: 65627f3a0908210307m3f3cda72vde9722d2db6b9289 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


2009/8/18 Sebastian Kügler <sebas@kde.org>

> On Tuesday 18 August 2009 13:44:50 Alessandro Diaferia wrote:
> > 2009/8/17 Sebastian Kügler <sebas@kde.org>
> > I've updated the patch and now it correctly shows the capacity bar.
> There's
> > only a little issue: as soon as the device gets "mounted" the engine does
> > not return a valid "Free Space" data. This is probably a problem with the
> > engine or, worse, with solid.. Will check it out though..
>
> Cool, Alessandro :)
>
> Once you find out what the problem is, can you commit the patch? I'm on a
> business
> trip right now and don't have my kdebase checkout on the laptop I've taken
> with me.
>
> Thanks,
> --
> sebas
>
> http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
>

Ok, engine fixed according to Aaron's suggestion and patch committed =)

Cheers and thanks to Martin for his huge work on the patch!

-- 
Alessandro Diaferia
KDE Developer

[Attachment #5 (text/html)]

<br><br><div class="gmail_quote">2009/8/18 Sebastian Kügler <span dir="ltr">&lt;<a \
href="mailto:sebas@kde.org">sebas@kde.org</a>&gt;</span><br><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"> <div class="im">On Tuesday 18 August 2009 13:44:50 \
Alessandro Diaferia wrote:<br> &gt; 2009/8/17 Sebastian Kügler &lt;<a \
href="mailto:sebas@kde.org">sebas@kde.org</a>&gt;<br> </div><div class="im">&gt; \
I&#39;ve updated the patch and now it correctly shows the capacity bar. \
There&#39;s<br> &gt; only a little issue: as soon as the device gets \
&quot;mounted&quot; the engine does<br> &gt; not return a valid &quot;Free \
Space&quot; data. This is probably a problem with the<br> &gt; engine or, worse, with \
solid.. Will check it out though..<br> <br>
</div>Cool, Alessandro :)<br>
<br>
Once you find out what the problem is, can you commit the patch? I&#39;m on a \
business<br> trip right now and don&#39;t have my kdebase checkout on the laptop \
I&#39;ve taken with me.<br> <br>
Thanks,<br>
<font color="#888888">--<br>
sebas<br>
<br>
<a href="http://www.kde.org" target="_blank">http://www.kde.org</a> | <a \
href="http://vizZzion.org" target="_blank">http://vizZzion.org</a> | GPG Key ID: 9119 \
0EF9<br> </font></blockquote></div><br>Ok, engine fixed according to Aaron&#39;s \
suggestion and patch committed =)<br><br>Cheers and thanks to Martin for his huge \
work on the patch!<br clear="all"><br>-- <br>Alessandro Diaferia<br> KDE \
Developer<br>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]