[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [PATCH] BUG 203716 give user a hint when adding same application
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2009-08-17 22:35:08
Message-ID: 200908171635.08844.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Friday 14 August 2009, 潘卫平(Peter Pan) wrote:
> svn r 1011382

there are a couple issues with this patch, unfortunately. first, it introduces 
a modal dialog. that will block the rest of plasma. not good. :/

second, the button names are just "Ok" and "Cancel", they should be changed to 
having meaningful labels that say _what_ will happen if "Ok" or "Cancel" is 
pressed. but that's a moot point, because we really can't have a modal dialog 
here.

is there any use case where it makes sense to have more than one icon for the 
_same_ application or file? i can't think of one. so i'd suggest just silently 
dropping duplicates.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]