[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Simplest Image Hosting support for pastebin applet
From:       "Artur de Souza \(MoRpHeUz\)" <asouza () kde ! org>
Date:       2009-08-10 16:50:56
Message-ID: 20090810165056.21924.55762 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1251/#review1964
-----------------------------------------------------------



/trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp
<http://reviewboard.kde.org/r/1251/#comment1316>

    Minor but important: not sure if kdeplasma-addons have coding style guidelines \
but following kdelibs, "if" statements should have the "{" on the same line :)  


- Artur


On 2009-08-10 16:41:16, Michal Dutkiewicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1251/
> -----------------------------------------------------------
> 
> (Updated 2009-08-10 16:41:16)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch adds support for Simplest Image Hosting \
> (http://simplest-image-hosting.net/) to pastebin applet. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396 
> /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396 
> /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h \
>                 PRE-CREATION 
> /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp \
>                 PRE-CREATION 
> /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396 
> /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396 
> /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396 
> /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui 1008396 
> 
> Diff: http://reviewboard.kde.org/r/1251/diff
> 
> 
> Testing
> -------
> 
> Works fine except showing error icon even if upload is successful (there is success \
> notification and link is added to history). 
> 
> Thanks,
> 
> Michal
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]