[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Simplest Image Hosting support for pastebin applet
From: "Chani" <chanika () gmail ! com>
Date: 2009-08-10 6:41:49
Message-ID: 20090810064149.3021.10512 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1251/#review1948
-----------------------------------------------------------
hmm, I can't really comment on the nontrivial parts of the code... I don't see \
anything bad, but I'm also half asleep. getting an error icon on success is bad...
/trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp
<http://reviewboard.kde.org/r/1251/#comment1305>
42 + 13?
/trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp
<http://reviewboard.kde.org/r/1251/#comment1304>
why are all these image server classes being cast to themselves?
- Chani
On 2009-08-09 21:08:23, Michal Dutkiewicz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1251/
> -----------------------------------------------------------
>
> (Updated 2009-08-09 21:08:23)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> This patch adds support for Simplest Image Hosting \
> (http://simplest-image-hosting.net/) to pastebin applet.
>
> Diffs
> -----
>
> /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396
> /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396
> /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h \
> PRE-CREATION
> /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp \
> PRE-CREATION
> /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396
> /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396
> /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396
> /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui 1008396
>
> Diff: http://reviewboard.kde.org/r/1251/diff
>
>
> Testing
> -------
>
> Works fine except showing error icon even if upload is successful (there is success \
> notification and link is added to history).
>
> Thanks,
>
> Michal
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic