[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: adds private imagebin to the pastebin plasmoid
From:       "Chani" <chanika () gmail ! com>
Date:       2009-08-09 22:59:40
Message-ID: 20090809225940.26250.8030 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1248/#review1945
-----------------------------------------------------------

Ship it!


looks good, only thing I can think of is we might want to hide the privacy option \
when imageshack is selected, since it doesn't apply to that site.

I assume you need someone to commit this for you? I've gotta run now, someone please \
take care of that :)


/trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt
<http://reviewboard.kde.org/r/1248/#comment1302>

    looks like you deleted this by accident


- Chani


On 2009-08-09 22:00:52, patcito wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1248/
> -----------------------------------------------------------
> 
> (Updated 2009-08-09 22:00:52)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This is my first patch, it just adds "posting private picture to
> imagebin.ca from the pastebin plasmoid" as the title says, it needs to
> be applied from kdeplasma-addons, hope it works for you.
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008583 
> /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.h 1008583 
> /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.cpp 1008583 
> /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008583 
> /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008583 
> 
> Diff: http://reviewboard.kde.org/r/1248/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> now in the main config page
> http://reviewboard.kde.org/r/1248/s/169/
> 
> 
> Thanks,
> 
> patcito
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]