[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [PATCH] BUG167947 pick a picture and set it as wallpaper in
From:       Chani <chanika () gmail ! com>
Date:       2009-08-06 20:39:21
Message-ID: 200908061339.29392.chanika () gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On August 6, 2009 03:53:10 Aaron J. Seigo wrote:
> On Thursday 06 August 2009, 潘卫平(Peter Pan) wrote:
> > In KDE 3 , it was possible to set a wallpaper by dragging a picture from
> > konqueror. And I implement this feature in Plasma::Containment.
>
> i don't think this is really the right place for this code (in
> Containment); rather, i think this would be better implemented as an
> extension to Chani's containment actions project.
>
> not all libplasma based applications will want to have images dropped on
> them setting the background, so this is really something that needs to be
> done per- application. being able to define the default actions for dropped
> data therefore seems to make more sense.

:/

I guess it'd be possible to move all the drag&drop code into the paste plugin 
and add a hack to store that plugin under some special key and call it with 
the drag event...
if it ever gets a config UI, though, you'd have trouble. right now they'd share 
the same config, which might be surprising. if I fix that then there'd be no way 
to configure drag&drop, unless you stick a button for it somewhere...


also, 潘, would you be able to put your patches on reviewboard.kde.org instead 
of emailing them? it's easier to track them there. :)

-- 
This message brought to you by eevil bananas and the number 3.
www.chani3.com

["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]