[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: gsoc mouse plugins: config UI
From:       "Chani" <chanika () gmail ! com>
Date:       2009-08-01 1:13:23
Message-ID: 20090801011323.30416.70042 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1198/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

this is the second of three patches I've finally persuaded reviewboard to accept.
it contains all my changes in shells/desktop/

The UI isn't perfect but I think it's good enough for people to figure out.
for more details see \
http://gitorious.org/plasma-mouse-plugins/kdebase-workspace-plasma/commits/gsoc and \
other branches. gsoc has the squashed commits, and master is just trunk with none of \
my changes.

known issues:
-I don't have an icon for the config page
-I'm not showing the icons of hte plugins (should we bother with icons for these \
                plugins?)
-the plugin entries could be better separated; having them all one after the other on \
                a plain grey background sucks
-the alignment isn't quite right; you can see one plugin with a longer description \
                has smaller buttons. :/
-I don't really like having a popup for the plugins' own config, but I can't think of \
                a nicer way to do it.
-that popup is Qt::WindowModal, which means it shouldn't interfere with plasma, but \
somehow tooltips don't work while it's up. I don't think many people will notice \
                that, though ;)
-the code for the abou dialog is ugly copy&paste. after gsoc I'd like to fix the \
issue in kdelibs.


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/CMakeLists.txt 1005079 
  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/MousePluginWidget.ui \
PRE-CREATION   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/MousePlugins.ui \
PRE-CREATION   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/backgrounddialog.h \
1005079   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/backgrounddialog.cpp \
1005079   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/desktopview.cpp 1005079 
  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/mouseinputbutton.h PRE-CREATION 
  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/mouseinputbutton.cpp \
PRE-CREATION   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/mouseplugins.h \
PRE-CREATION   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/mouseplugins.cpp \
PRE-CREATION   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/mousepluginwidget.h \
PRE-CREATION   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/mousepluginwidget.cpp \
PRE-CREATION 

Diff: http://reviewboard.kde.org/r/1198/diff


Testing
-------


Screenshots
-----------

config ui
  http://reviewboard.kde.org/r/1198/s/159/
configuring the test plugin
  http://reviewboard.kde.org/r/1198/s/160/


Thanks,

Chani

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]