From kde-panel-devel  Wed Jul 29 18:42:25 2009
From: "Aaron Seigo" <aseigo () kde ! org>
Date: Wed, 29 Jul 2009 18:42:25 +0000
To: kde-panel-devel
Subject: Re: Review Request: Add clear() method to Plasma::TabBar widget
Message-Id: <20090729184225.1123.84029 () localhost>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=124889297100526


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1146/#review1842
-----------------------------------------------------------


i assume the reason there is no QTabWidget::clear() is that it isn't something that gets used very often and is easy to do outside the API, so for API simplicity hasn't ever been added. personally i'm Ok with this patch as long as there is more than one user of it.


svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/tabbar.cpp
<http://reviewboard.kde.org/r/1146/#comment1210>

    should the preferred size of the tabProxy be updated at this point? e.g.:
    
    d->tabProxy->setPreferredSize(d->tabProxy->native->sizeHint());
    
    insert/remove tab are doing this, so i assume it should be done here as well.


- Aaron


On 2009-07-28 06:22:04, Shawn Starr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1146/
> -----------------------------------------------------------
> 
> (Updated 2009-07-28 06:22:04)
> 
> 
> Review request for Plasma, Aaron Seigo and Marco Martin.
> 
> 
> Summary
> -------
> 
> Add a clear() method to the Plasma::TabBar widget, It seems odd to require the user to have to iterate though all the tabs to delete them when this really should be done internally. It's seems strange QTabBar also has no clear() to deal with this. Maybe someone can explain why this is the case?
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/tabbar.h 1003358 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/tabbar.cpp 1003358 
> 
> Diff: http://reviewboard.kde.org/r/1146/diff
> 
> 
> Testing
> -------
> 
> 1) call clear() with no tabs added to a Plasma::TabBar instance, result function exits and nothing happens.
> 2) call clear() with tabs added, add and remove them with different sizes, tabs are destroyed properly. We are assuming that if there are N pages there are N tabs. As I didn't see any method to return the total number of tabs only pages.
> 
> 
> Thanks,
> 
> Shawn
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel