From kde-panel-devel  Wed Jul 29 09:50:54 2009
From: =?utf-8?q?Sebastian_K=C3=BCgler?= <sebas () kde ! org>
Date: Wed, 29 Jul 2009 09:50:54 +0000
To: kde-panel-devel
Subject: Re: Review Request: Add next and previous buttons to Frame applet
Message-Id: <20090729095054.20318.32835 () localhost>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=124886110611357


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1028/#review1833
-----------------------------------------------------------

Ship it!


Patch looks fine, other than some minor coding style things, it's good to go IMO


trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp
<http://reviewboard.kde.org/r/1028/#comment1199>

    we use braces also for single indented lines



trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp
<http://reviewboard.kde.org/r/1028/#comment1200>

    braces please also for single lines


- Sebastian


On 2009-07-28 20:22:17, Arthur Mello wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1028/
> -----------------------------------------------------------
> 
> (Updated 2009-07-28 20:22:17)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> As mentioned on Frame TODO this patch adds buttons to navigate through slide show.
> Buttons appear when mouse is over applet and only when applet is doing a slideshow.
> Example code at TODO put the buttons above the pictue, I placed them on left and right borders, but I can change this if necessary.   
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1003781 
>   trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1003781 
>   trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1003781 
>   trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1003781 
> 
> Diff: http://reviewboard.kde.org/r/1028/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Slide show buttons
>   http://reviewboard.kde.org/r/1028/s/155/
> 
> 
> Thanks,
> 
> Arthur
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel