[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Add clear() method to Plasma::TabBar widget
From:       "Shawn Starr" <shawn.starr () rogers ! com>
Date:       2009-07-28 6:22:07
Message-ID: 20090728062207.15181.30413 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1146/
-----------------------------------------------------------

Review request for Plasma, Aaron Seigo and Marco Martin.


Summary
-------

Add a clear() method to the Plasma::TabBar widget, It seems odd to require the user \
to have to iterate though all the tabs to delete them when this really should be done \
internally. It's seems strange QTabBar also has no clear() to deal with this. Maybe \
someone can explain why this is the case?


Diffs
-----

  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/tabbar.h 1003358 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/tabbar.cpp 1003358 

Diff: http://reviewboard.kde.org/r/1146/diff


Testing
-------

1) call clear() with no tabs added to a Plasma::TabBar instance, result function \
exits and nothing happens. 2) call clear() with tabs added, add and remove them with \
different sizes, tabs are destroyed properly. We are assuming that if there are N \
pages there are N tabs. As I didn't see any method to return the total number of tabs \
only pages.


Thanks,

Shawn

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]