[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fix layout problems in the pager applet
From:       "Anthony Bryant" <antjbryant () gmail ! com>
Date:       2009-07-27 1:04:50
Message-ID: 20090727010450.10795.73506 () localhost
[Download RAW message or body]



> On 2009-07-27 00:35:33, Aaron Seigo wrote:
> > just found a "small" problem when doing some more testing before commit: when \
> > it's in a non horiz/vert form factor (e.g. planar, aka "the desktop") the size of \
> > the desktop bits don't scale down consistently to fit the width. you can test \
> > this easily with `plasmoidviewer pager`

Hmm... I don't think I can reproduce it here...
When I test it (both in plasmoidviewer and on the desktop) it scales the virtual \
desktop rectangles properly whenever it is resized. The problem you described \
actually sounds like how it was before this patch if I remember rightly...


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1124/#review1802
-----------------------------------------------------------


On 2009-07-25 21:40:41, Anthony Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1124/
> -----------------------------------------------------------
> 
> (Updated 2009-07-25 21:40:41)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch fixes a few problems with the pager that are especially apparent in \
> vertical panels. Specifically, the rows and columns are unnecessarily swapped in \
> recalculateGeometry() which causes bug 200013. Also, due to the way the rectangle \
> sizes were calculated it was possible for certain areas to be clipped. This patch \
> makes sure every item can fit into the current space. This also fixes a bug I only \
> noticed when reading the code, where extra unnecessary columns could be added if \
> desktopCount % rows > 1 
> My main concern about this patch is that it removes a mechanism for ignoring some \
> constraints events, I think these events are needed in order to avoid clipping some \
> of the virtual desktops, but I'm not sure how to reproduce the bug that made this \
> filtering necessary in the first place. 
> 
> This addresses bug 200013.
> https://bugs.kde.org/show_bug.cgi?id=200013
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/plasma/applets/pager/pager.h 1002081 
> /trunk/KDE/kdebase/workspace/plasma/applets/pager/pager.cpp 1002081 
> 
> Diff: http://reviewboard.kde.org/r/1124/diff
> 
> 
> Testing
> -------
> 
> Tested in vertical and horizontal panels and on the desktop.
> 
> 
> Thanks,
> 
> Anthony
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]