[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Allow AbstractRunner to parse QMenus for actions
From:       "Chani" <chanika () gmail ! com>
Date:       2009-07-25 2:56:18
Message-ID: 20090725025618.20582.56925 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1115/#review1758
-----------------------------------------------------------

Ship it!


I don't really know anything about runners, but the code looks good to me.


trunk/KDE/kdelibs/plasma/abstractrunner.cpp
<http://reviewboard.kde.org/r/1115/#comment1147>

    hrm. if it's a submenu and checkable, it's going to look like Foo: (x) Bar
    that is what you intended, right? not
    (x) Foo: Bar


- Chani


On 2009-07-25 01:24:26, Ryan Bitanga wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1115/
> -----------------------------------------------------------
> 
> (Updated 2009-07-25 01:24:26)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This adds a convenience method to AbstractRunner to extract a list of actions from \
> a QMenu. Hierarchy is preserved by prefixing submenu text to the actions in the \
> submenus. 
> Current uses are extracting actions from KFileItemActions and libtaskmanager. The \
> code is currently used by the window management runner in playground, the multiple \
> action nepomuk search runner patch in reviewboard, and fsrunner in kde-apps.org. \
> This method will help avoid code duplication in these runners as well as future \
> runners that can extract info from menus. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdelibs/plasma/abstractrunner.h 1001909 
> trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1001909 
> 
> Diff: http://reviewboard.kde.org/r/1115/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryan
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]