[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Custom combo boxes for Plasma::ComboBox
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2009-07-21 18:37:18
Message-ID: 20090721183718.8991.6231 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1094/#review1705
-----------------------------------------------------------


I like the idea,since doesn't make sense a new plasma widget for every conceivale \
thing, i think adding the possibility (just for c++ ones?) of putting a subclass in \
does make the thing more flexible while not putting too many exported symbols of \
course if it's ok for the combobox it should be done for all proxywidgets, either all \
of them or nothing :)

- Marco


On 2009-07-21 15:55:33, Michal Dutkiewicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1094/
> -----------------------------------------------------------
> 
> (Updated 2009-07-21 15:55:33)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Summary
> -------
> 
> This patch adds possibility to use custom combo box widgets (subclassed from \
> KComboBox) instead of plain KComboBox. It's intended for 4.3 (better later than \
> never..., didn't know that there is still no possibility to do something like this \
> and no possibility to create custom Plasma themed widget). It adds new constructor \
> to set widget without creating new like in first. It will be used by Run Command \
> applet (KHistoryComboBox, waiting for theming possibility for very long time) and \
> probably by others in the future. If it will be accepted I'll probably prepare \
> similar patches to some other widgets (most common) for consistency and bigger \
> flexibility that comes without costs (as far as I know). 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/plasma/widgets/combobox.h 1000582 
> /trunk/KDE/kdelibs/plasma/widgets/combobox.cpp 1000582 
> 
> Diff: http://reviewboard.kde.org/r/1094/diff
> 
> 
> Testing
> -------
> 
> Tested by my friend, compiles and works.
> 
> 
> Screenshots
> -----------
> 
> Plasma themed KHistoryComboBox in Run Command applet
> http://reviewboard.kde.org/r/1094/s/151/
> 
> 
> Thanks,
> 
> Michal
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]