[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Add gradients to the plasma color wallpaper
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2009-07-05 7:49:32
Message-ID: 20090705074932.22099.23236 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/939/#review1472
-----------------------------------------------------------

Ship it!


the colour plugin should just do colours, not images. this would more appropriately \
be added to the image plugin which already supports a background colour, but i'm not \
sure there's enough benefit to it to justify the extra configuration UI it would \
carry with it ... or maybe it would be neat to have multiple wallpapers at once ;) \
(that's not a serious suggestion, btw).

- Aaron


On 2009-07-04 22:54:17, Shafqat Bhuiyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/939/
> -----------------------------------------------------------
> 
> (Updated 2009-07-04 22:54:17)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch adds the ability to have gradients in the plasma color wallpaper. The \
>                 following gradient types have been added:
> - Solid (single plain color)
> - Horizontal
> - Vertical
> - Rectangular
> - Radial
> - Top Left Diagonal
> - Top Right Diagonal
> 
> If there are any other types of gradients that you want please tell me :)
> 
> I also thought of adding the possibility to blend the gradient with an image. Is \
> that suitable for the color wallpaper or would that be overkill? 
> 
> This addresses bug 194272.
> https://bugs.kde.org/show_bug.cgi?id=194272
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/plasma/wallpapers/color/color.h 990161 
> /trunk/KDE/kdebase/workspace/plasma/wallpapers/color/color.cpp 990161 
> /trunk/KDE/kdebase/workspace/plasma/wallpapers/color/config.ui 990161 
> /trunk/KDE/kdebase/workspace/plasma/wallpapers/color/plasma-wallpaper-color.desktop \
> 990161  
> Diff: http://reviewboard.kde.org/r/939/diff
> 
> 
> Testing
> -------
> 
> Initial testing revealed some bugs which have been fixed.
> 
> 
> Thanks,
> 
> Shafqat
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]