[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: [PATCH] BUG 198888 & BUG 198890 about icon and text on plasma
From: <panweiping3 () gmail ! com>
Date: 2009-07-05 1:59:49
Message-ID: 499f24540907041859g53c1b15i2a3c68b0975778cd () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
2009/7/5 Aaron J. Seigo <aseigo@kde.org>
> On Saturday 04 July 2009, ÅËÎÀƽ wrote:
> > BUG 198888 plasma applet tasks doesn't have an icon on tooltip, because
> we
> > don't set an icon in TaskGroupItem updateTooltip function. Apply
> > kdebase-plasma-tasks-groupicon.patch to
> > kdebase/workspace/plasma/applets/tasks/ can fix this bug.
>
> yes, that's a good addition.
>
> > BUG 198890 The positions of icon and text on plasma tooltip aren't
> > consistent when grouping or not, because the plasma tooltip only has a
> > . When you enable kwin taskbar thumbnail effect, it cann't work
> > finefor previews, icon and text.
> >
> > So I add previews into a QHBoxLayout, add icon and text into another
> > QHBoxLayout, and set the stretch factor of text is 1, and and both
> > QHBoxLayouts into a QVBoxLayout. These make the items on tooltip looks
> > consistent. kdelibs-tooltip-alignment.patch should be applied to
> > kdelibs/plasma/.
>
> while the patch looks ok, there's no reason the exact same thing couldn't
> be
> done with a QGridLayout. it also supports setting the stretch, alignment,
> etc.
>
> by the way, do you have a commit account for KDE's svn? if you do, please
> commit the above patches (and close the bugs on bugs.kde.org :). if you
> don't,
> please visit http://techbase.kde.org/Contribute/Get_a_SVN_Account and
> apply
> for one as it is best if you can commit these kinds of patches directly
> yourself. :)
>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Qt Software
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
Yes, QGridLayout can do this too.
And I have applied for a SVN account just now. Thanks for your
encouragement!
--
ÅËÎÀƽ(Peter Pan)
[Attachment #5 (text/html)]
<br><div class="gmail_quote">2009/7/5 Aaron J. Seigo <span dir="ltr"><<a \
href="mailto:aseigo@kde.org">aseigo@kde.org</a>></span><br><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"> <div class="im">On Saturday 04 July 2009, ÅËÎÀƽ \
wrote:<br> > BUG 198888 plasma applet tasks doesn't have an icon on tooltip, \
because we<br> > don't set an icon in TaskGroupItem updateTooltip function. \
Apply<br> > kdebase-plasma-tasks-groupicon.patch to<br>
> kdebase/workspace/plasma/applets/tasks/ can fix this bug.<br>
<br>
</div>yes, that's a good addition.<br>
<div class="im"><br>
> BUG 198890 The positions of icon and text on plasma tooltip aren't<br>
> consistent when grouping or not, because the plasma tooltip only has a<br>
> . When you enable kwin taskbar thumbnail effect, it cann't work<br>
> finefor previews, icon and text.<br>
><br>
> So I add previews into a QHBoxLayout, add icon and text into another<br>
> QHBoxLayout, and set the stretch factor of text is 1, and and both<br>
> QHBoxLayouts into a QVBoxLayout. These make the items on tooltip looks<br>
> consistent. kdelibs-tooltip-alignment.patch should be applied to<br>
> kdelibs/plasma/.<br>
<br>
</div>while the patch looks ok, there's no reason the exact same thing \
couldn't be<br> done with a QGridLayout. it also supports setting the stretch, \
alignment, etc.<br> <br>
by the way, do you have a commit account for KDE's svn? if you do, please<br>
commit the above patches (and close the bugs on <a href="http://bugs.kde.org" \
target="_blank">bugs.kde.org</a> :). if you don't,<br> please visit <a \
href="http://techbase.kde.org/Contribute/Get_a_SVN_Account" \
target="_blank">http://techbase.kde.org/Contribute/Get_a_SVN_Account</a> and \
apply<br> for one as it is best if you can commit these kinds of patches directly<br>
yourself. :)<br>
<font color="#888888"><br>
--<br>
Aaron J. Seigo<br>
humru othro a kohnu se<br>
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43<br>
<br>
KDE core developer sponsored by Qt Software<br>
</font><br>_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> \
<br></blockquote></div><br><br clear="all">Yes, QGridLayout can do this too.<br> <br>
And I have applied for a SVN account just now. Thanks for your \
encouragement!<br><br>-- <br>ÅËÎÀƽ(Peter Pan)<br>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic