[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Fix resizing issues in krunner
From:       "Jacopo De Simoi" <wilderkde () gmail ! com>
Date:       2009-07-01 7:21:14
Message-ID: 20090701072114.10994.11006 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/911/
-----------------------------------------------------------

Review request for Plasma and Aaron Seigo.


Summary
-------

This patch attempts to fix various inconsistencies that appear when resizing krunner \
and also provides some minor optimization to the drawing path. As per a discussion in \
                irc, here is the default resizing behaviour:
- allow the user to resize krunner, and keep the new size along sessions.
- allow the user to move krunner, but reset the position along sessions.
Comments in the patch are quite self-explanatory; in particular I believe to have hit \
a qt bug which I do not fully understand; as soon as I'll dig into it I'll open a qt \
task if necessary. A few remarks:
- I put the results view and the cosmetic divider line in a resultsContainer so that \
                showing the results won't trigger too many resizes.
- I added some hide() here and there again to avoid drawing resizes right before \
                hiding the window
- I corrected a bug in handling resizing of the items; there might be a more elegant \
way to deal with it. If this is the case, please let me know.  Thanks


Diffs
-----

  branches/KDE/4.3/kdebase/workspace/krunner/interfaces/default/interface.h 989181 
  branches/KDE/4.3/kdebase/workspace/krunner/interfaces/default/interface.cpp 989181 
  branches/KDE/4.3/kdebase/workspace/krunner/interfaces/default/resultitem.h 989181 
  branches/KDE/4.3/kdebase/workspace/krunner/interfaces/default/resultitem.cpp 989181 \
  branches/KDE/4.3/kdebase/workspace/krunner/interfaces/default/resultscene.cpp \
989181 

Diff: http://reviewboard.kde.org/r/911/diff


Testing
-------


Thanks,

Jacopo

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]