[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Activate present windows from task group context
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2009-06-27 22:22:07
Message-ID: 20090627222207.5747.16641 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/897/
-----------------------------------------------------------

(Updated 2009-06-27 15:22:07.327479)


Review request for Plasma.


Changes
-------

Added activating present windows to task group item. That is when clicking on the \
group item present windows will be shown instead of the popup menu. It checks if \
present windows is announced by kwin and if it is not available the normal popup will \
be used.


Summary
-------

Patch adds a new menu entry to task group context menu to show the group of windows \
in kwin's present windows effect. When this entry is selected the window ids of the \
tasks listed in the group are passed to an XAtom which activates present windows \
effect for the passed windows (other windows will be hidden). The atom will be \
removed by present windows effect when it get's disabled.

This patch requires current kwin from trunk. What's missing is the detection if \
present windows effect is available or not (e.g. compositing not active, Compiz used \
instead of KWin). KWin announces support via setting atom on root window.


Diffs (updated)
-----

  trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp 988181 

Diff: http://reviewboard.kde.org/r/897/diff


Testing
-------

Tested with both manual and automatic grouping.


Thanks,

Martin

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]