[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Activate present windows from task group context
From:       "Ivan Cukic" <ivan.cukic+kde () gmail ! com>
Date:       2009-06-27 12:21:54
Message-ID: 20090627122154.25483.33855 () localhost
[Download RAW message or body]



> On 2009-06-27 04:53:14, Marco Martin wrote:
> > i like it!
> > i was also experimenting in the taskbar applet, (like with clicking on the group \
> > while pressing control) and mostly ended up with duplicate code, now, i am \
> > wondering: what about providing a TaskGroupItem::presentWindows()? (that would \
> > basically be a carbon copy of PresentWindowsActionImpl) in this way it could be \
> > used by the context menu -and- by the applet..
> 
> Michal Dutkiewicz wrote:
> Good idea. :-)

Nice idea.

As a side note, are we adding too many inconsistent and sometimes hidden features \
that have the same purpose?

Group -> click -> menu of item in the group
Group -> hover -> popup with window thumbnails, click a thumbnail and it opens \
[obscure feature] Group -> RMB -> menu item -> present windows
Group -> ctrl+click* -> present windows [hidden feature]

Maybe we should have the /effect/ to be used when you click changeable by the user \
like it is for alt-tab, desktop switching...?


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/897/#review1397
-----------------------------------------------------------


On 2009-06-27 04:30:57, Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/897/
> -----------------------------------------------------------
> 
> (Updated 2009-06-27 04:30:57)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Patch adds a new menu entry to task group context menu to show the group of windows \
> in kwin's present windows effect. When this entry is selected the window ids of the \
> tasks listed in the group are passed to an XAtom which activates present windows \
> effect for the passed windows (other windows will be hidden). The atom will be \
> removed by present windows effect when it get's disabled. 
> This patch requires current kwin from trunk. What's missing is the detection if \
> present windows effect is available or not (e.g. compositing not active, Compiz \
> used instead of KWin). KWin announces support via setting atom on root window. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp 972097 
> trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions_p.h 972097 
> 
> Diff: http://reviewboard.kde.org/r/897/diff
> 
> 
> Testing
> -------
> 
> Tested with both manual and automatic grouping.
> 
> 
> Thanks,
> 
> Martin
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]