[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fix Plasma clocks not being aware of timezone
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2009-06-26 10:12:23
Message-ID: 20090626101223.26150.97158 () localhost
[Download RAW message or body]



> On 2009-06-25 17:30:44, Jacopo De Simoi wrote:
> > Much better than mine!
> > It would be excellent if we could trigger an update of all the containers \
> > attached but I just can't find the way to do it (is it possible?) Right now it \
> > waits for next trigger to update all clocks, which can be in fact be quite \
> > confusing, as the user can have to wait 1 minute to have it set.

i actually have a patch on disk for that; i never found a use case for it, but maybe \
now we have one. i'll post that patch in a moment.


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/891/#review1384
-----------------------------------------------------------


On 2009-06-25 16:34:27, Aaron Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/891/
> -----------------------------------------------------------
> 
> (Updated 2009-06-25 16:34:27)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Alternate patch to http://reviewboard.kde.org/r/889/ 
> 
> from 889: "The plasma timeengine reacts to timezone changes, but the timesource \
> does not; this patch filles the gap." 
> the benefit of this patch is that the change is done in one place, no \
> synchronization issues based on who gets a signal first. (i wonder if it needs to \
> update all the timezones, even, or just the local one? not that updateAllSources is \
> slow, so it shouldn't matter..) 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/workspace/plasma/dataengines/time/timeengine.h 980060 
> trunk/KDE/kdebase/workspace/plasma/dataengines/time/timeengine.cpp 980060 
> trunk/KDE/kdebase/workspace/plasma/dataengines/time/timesource.h 980060 
> trunk/KDE/kdebase/workspace/plasma/dataengines/time/timesource.cpp 980060 
> 
> Diff: http://reviewboard.kde.org/r/891/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aaron
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]