[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Fix Plasma clocks not being aware of timezone changes
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2009-06-25 23:34:27
Message-ID: 20090625233427.13392.82703 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/891/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Alternate patch to http://reviewboard.kde.org/r/889/ 

from 889: "The plasma timeengine reacts to timezone changes, but the timesource does \
not; this patch filles the gap."

the benefit of this patch is that the change is done in one place, no synchronization \
issues based on who gets a signal first. (i wonder if it needs to update all the \
timezones, even, or just the local one? not that updateAllSources is slow, so it \
shouldn't matter..)


Diffs
-----

  trunk/KDE/kdebase/workspace/plasma/dataengines/time/timeengine.h 980060 
  trunk/KDE/kdebase/workspace/plasma/dataengines/time/timeengine.cpp 980060 
  trunk/KDE/kdebase/workspace/plasma/dataengines/time/timesource.h 980060 
  trunk/KDE/kdebase/workspace/plasma/dataengines/time/timesource.cpp 980060 

Diff: http://reviewboard.kde.org/r/891/diff


Testing
-------


Thanks,

Aaron

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]