[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: BackgroundListModel::removeBackground must be a
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2009-06-25 23:12:49
Message-ID: 20090625231249.13241.55425 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/883/#review1382
-----------------------------------------------------------


good catch; it can even go into protected slots, and this change needs to also be \
made to the two wallpapers that duplicate this code in plasma-addons. i'll take care \
of that .. thanks for patch :)

- Aaron


On 2009-06-25 02:38:01, Omer F. USTA wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/883/
> -----------------------------------------------------------
> 
> (Updated 2009-06-25 02:38:01)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> @backgroundlistmodel.cpp: 
> connect(&m_dirwatch, SIGNAL(deleted(QString)), this, \
> SLOT(removeBackground(QString))); 
> used as Slot but it wasn't defined as slot in .h file
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundlistmodel.h 986882 
> 
> Diff: http://reviewboard.kde.org/r/883/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Omer F.
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]