[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Cannot remove scripted plasmoid
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2009-06-19 19:06:36
Message-ID: 200906191306.37198.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Friday 19 June 2009, Petri Damstén wrote:
> On Thursday 18 June 2009 22:23:58 Chani wrote:
> > On June 18, 2009 09:15:27 Petri Damstén wrote:
> > > On Saturday 13 June 2009 10:10:44 Petri Damstén wrote:
> > > > > doh! that was in the wrong init() method (the private vs the public
> > > > > one) .. it's fixed now :)
> > > >
> > > > I think that X-Plasma-DefaultSize code should be still called from
> > > > private init, since public init is too late for that?
> >
> > yes.
> >
> > > I was a way for a while but now I had finally time to test this. Seems
> > > that now plasma always resizes scripted applets to default size. Could
> > > X-Plasma- DefaultSize code work for C++ (like in attached patch) or
> > > should it be in the script specific section of the code in the
> > > AppletPrivate::init?
> > >
> > > Petri
> >
> > c++ plasmoids have been setting default size in their constructors, so
> > it's probably best not to override that :)
>
> AppletPrivate::init is called from Plasma::Applet constructor so it gets
> run before actual Applet constructor where resize usually is? I was
> thinking that it could be used for C++ too for consistency but would not
> break existing applets.

that's fine with me.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software


["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]