-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/775/#review1218
-----------------------------------------------------------

Ship it!


the whitespace/alignment in the eventFilter of the new class is a bit messed up, but the actual logic looks good and in line with our previous conversations. pls clean up the ws and commit :)

- Aaron


On 2009-05-28 09:07:51, Jacopo De Simoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/775/
> -----------------------------------------------------------
> 
> (Updated 2009-05-28 09:07:51)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> Krunner has some issues with the TAB key; KLineEdit autocompletes automatically when losing focus, so the overall behavior is confusing.
> This patch filters the tab events and introduces a consistent behavior;
> I am personally not 100% sure about what would be the "expected" behavior, so I ask for a review;
> the patch has comments to explain the various cases.
> Any comment is welcome. Should I ask also on kde-usability?
> 
> 
> This addresses bug 192605.
>     https://bugs.kde.org/show_bug.cgi?id=192605
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp 973024 
>   trunk/KDE/kdebase/workspace/krunner/interfaces/default/krunnertabfilter.h PRE-CREATION 
>   trunk/KDE/kdebase/workspace/krunner/interfaces/default/krunnertabfilter.cpp PRE-CREATION 
>   trunk/KDE/kdebase/workspace/krunner/interfaces/default/resultscene.cpp 973024 
> 
> Diff: http://reviewboard.kde.org/r/775/diff
> 
> 
> Testing
> -------
> 
> Done basic testing and it works
> 
> 
> Thanks,
> 
> Jacopo
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel