[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: config
From:       "Chani" <chanika () gmail ! com>
Date:       2009-05-03 19:29:46
Message-ID: 20090503192946.13884.48329 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/639/
-----------------------------------------------------------

(Updated 2009-05-03 12:29:46.686527)


Review request for Plasma.


Changes
-------

ok, last change before I commit :) squished a couple of regressions.

-made sure containments always have a config action (aaron, there's a FIXME line in \
                setHasConfig... because the code doesn't look quite right)
-set the text for remove & configure at the right time so that everyone gets the text \
they expect. I'm not 100% happy with it because it sets the text in two places, but \
it's the best I could come up with.


Summary
-------

-needs testing without my local patch that fixes a qt shortcut bug


Diffs (updated)
-----

  /trunk/KDE/kdelibs/plasma/applet.h 961912 
  /trunk/KDE/kdelibs/plasma/applet.cpp 961912 
  /trunk/KDE/kdelibs/plasma/containment.cpp 961912 
  /trunk/KDE/kdelibs/plasma/corona.h 961912 
  /trunk/KDE/kdelibs/plasma/corona.cpp 961912 
  /trunk/KDE/kdelibs/plasma/private/applet_p.h 961912 
  /trunk/KDE/kdelibs/plasma/private/containment_p.h 961912 

Diff: http://reviewboard.kde.org/r/639/diff


Testing
-------


Thanks,

Chani

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]