[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: non-modal mode for KShortcutsDialog
From:       "Chani" <chanika () gmail ! com>
Date:       2009-05-03 16:43:17
Message-ID: 20090503164317.9654.49679 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/652/#review1041
-----------------------------------------------------------


if nobody objects to this patch I'll commit it in 10 hours.

- Chani


On 2009-05-01 19:49:41, Chani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/652/
> -----------------------------------------------------------
> 
> (Updated 2009-05-01 19:49:41)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Summary
> -------
> 
> kshortcutsdialog was designed to be modal and only modal. that doesn't work very \
> well for plasma. :) I added the possibility to use it non-modally. I need this to \
> finish off http://reviewboard.kde.org/r/639/ 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/kdeui/dialogs/kshortcutsdialog.h 961912 
> /trunk/KDE/kdelibs/kdeui/dialogs/kshortcutsdialog.cpp 961912 
> 
> Diff: http://reviewboard.kde.org/r/652/diff
> 
> 
> Testing
> -------
> 
> modal and non-modal modes work with the plasma settings dialog
> 
> 
> Thanks,
> 
> Chani
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]