From kde-panel-devel Wed Apr 29 04:17:04 2009 From: Chani Date: Wed, 29 Apr 2009 04:17:04 +0000 To: kde-panel-devel Subject: Re: Review Request: Message-Id: <200904282117.11236.chanika () gmail ! com> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=124097877709491 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0217853760==" --===============0217853760== Content-Type: multipart/signed; boundary="nextPart37631312.6jaoxHWnue"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit --nextPart37631312.6jaoxHWnue Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On April 28, 2009 17:20:53 Aaron Seigo wrote: > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/637/#review1000 > ----------------------------------------------------------- > > > other than moving the config method to Corona (nice symmetry with > containment->config() and applet->config()) it looks good. oh, huh, I didn't think reviewboard would let you review a discarded patch.= =2E.=20 o.0 I discovered kactioncollection methods that make this patch 90% irrelevant. =2D-=20 This message brought to you by eevil bananas and the number 3. www.chani3.com --nextPart37631312.6jaoxHWnue Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEABECAAYFAkn31MEACgkQeGbAwpIS3GwoewCfSEWJnIdfbeKzKDdrinbRWlaB C4AAoKlYQtwXP0v6y0Lb2wqDYUdcK/Ns =HMpG -----END PGP SIGNATURE----- --nextPart37631312.6jaoxHWnue-- --===============0217853760== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0217853760==--