[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fix special case arising from r954107
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2009-04-20 15:53:36
Message-ID: 20090420155336.19028.42308 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/614/#review973
-----------------------------------------------------------

Ship it!


- Aaron


On 2009-04-19 23:54:07, Alan Alpert wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/614/
> -----------------------------------------------------------
> 
> (Updated 2009-04-19 23:54:07)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> r954107 seems to have caused the weather dataengine to do nothing if Solid cannot \
> find out the network status. This patch lets the weather dataengine attempt to \
> obtain the data in the event that solid cannot discover the network status. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/workspace/plasma/dataengines/weather/weatherengine.cpp 956394 
> 
> Diff: http://reviewboard.kde.org/r/614/diff
> 
> 
> Testing
> -------
> 
> It was confirmed that solid returns a network status of 'Unknown' on my machine. \
> After applying this patch to r955998 of the weather dataengine the weather \
> plasmoids were able to both retrieve weather data and location verification data \
> (when configuring) - neither of which was working without this patch.  
> 
> Thanks,
> 
> Alan
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]