[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Use libplasmaweather in Weather Wallpaper
From:       Petri_Damstén <petri.damsten () gmail ! com>
Date:       2009-04-15 8:22:19
Message-ID: 20090415082219.26812.55702 () localhost
[Download RAW message or body]



> On 2009-04-14 16:22:53, Jonathan Thomas wrote:
> > Ooh, looks great! This port is greatly appreciated. Before, setting a new \
> > location after you set the first one didn't work at all. Now it works, unless you \
> > set a different location, then try to go back to your old location. (E.G. Set to \
> > manchester, new hampshire -> Hit OK (everything works), set it to a different \
> > location (say, San Francisco, California) -> hit OK (everything still works). But \
> > then, trying to go back to manchester, the wallpaper still stays at the one for \
> > San Francisco. This is, however, better than it used to be by far. :) 
> > Also, I assume later that I can manually add a button to WeatherConfig's layout \
> > so that I can reach the advanced setting for the wallpaper, correct? 
> > Thanks again!

Yes, layout of the widget is accessible with QWidget::layout().


- Petri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/589/#review922
-----------------------------------------------------------


On 2009-04-14 14:28:46, Petri Damstén wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/589/
> -----------------------------------------------------------
> 
> (Updated 2009-04-14 14:28:46)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Use libplasmaweather WeatherConfig widget in Weather Wallpaper.
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdeplasma-addons/wallpapers/weather/CMakeLists.txt 953924 
> /trunk/KDE/kdeplasma-addons/wallpapers/weather/weatherAddPlace.ui 953924 
> /trunk/KDE/kdeplasma-addons/wallpapers/weather/weatherLocations.ui 953924 
> /trunk/KDE/kdeplasma-addons/wallpapers/weather/weatherwallpaper.h 953924 
> /trunk/KDE/kdeplasma-addons/wallpapers/weather/weatherwallpaper.cpp 953924 
> 
> Diff: http://reviewboard.kde.org/r/589/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Petri
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]