[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Patch to use the iplocationtools.com geolocation
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2009-04-14 16:02:16
Message-ID: 20090414160216.4924.70282 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/584/#review917
-----------------------------------------------------------

Ship it!


looks good to me :) please commit...

- Aaron


On 2009-04-14 03:43:14, Andrew Coles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/584/
> -----------------------------------------------------------
> 
> (Updated 2009-04-14 03:43:14)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Patch to use the iplocationtools.com geolocation service with the geolocation \
> DataEngine.  Motivation is two-fold: 
> i) Better database (selfishly, it now works for me ;) )
> ii) Service returns latitude/longitude information - just as the GPS back-end does \
> - so anything using geolocation has a common denominator to work with, rather than \
> GPS returning lat/long and IP returning a place name. 
> 
> Diffs
> -----
> 
> /trunk/kdereview/plasma/dataengines/geolocation/location_ip.h 953569 
> /trunk/kdereview/plasma/dataengines/geolocation/location_ip.cpp 953569 
> 
> Diff: http://reviewboard.kde.org/r/584/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]