[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Prevent Plasma popups from showing over
From:       "Lucas Murray" <lmurray () undefinedfire ! com>
Date:       2009-04-10 4:36:13
Message-ID: 20090410043613.17249.14660 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/546/#review890
-----------------------------------------------------------


Although the old code also used the tool window type I would highly recommend against \
using the same technique again as it's only by chance that it does what it does and \
can be broken fairly innocently by both developers working on window managers or by \
the user just changing some settings. The correct fix would explicitly restack the \
popup behind the screensaver window or just not display any popups at all.

- Lucas


On 2009-04-09 09:04:21, Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/546/
> -----------------------------------------------------------
> 
> (Updated 2009-04-09 09:04:21)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Use Qt::Tool window flag to prevent passive Plasma popups from showing over \
> screensaver. 
> 
> This addresses bug 179924.
> https://bugs.kde.org/show_bug.cgi?id=179924
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/plasma/popupapplet.cpp 951469 
> 
> Diff: http://reviewboard.kde.org/r/546/diff
> 
> 
> Testing
> -------
> 
> Tested passive popup with battery notifications.
> Checked that KDE menu correctly gets keyboard focus when opened.
> 
> 
> Thanks,
> 
> Aurélien
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]