[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Patch regarding IRC discussion with Aron Seigo(its
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2009-04-03 21:10:06
Message-ID: 20090403211006.1139.72305 () localhost
[Download RAW message or body]



> On 2009-04-03 11:13:08, Sujith  H wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp, \
> > line 291 <http://reviewboard.kde.org/r/441/diff/6/?file=4695#file4695line291>
> > 
> > I believe this method fits here. Is this method wrong?

the problem is that it returns a bool when it should return a DisplayOrder (look at \
what m_displayOrder is :)


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/441/#review806
-----------------------------------------------------------


On 2009-04-02 12:34:04, Sujith  H wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/441/
> -----------------------------------------------------------
> 
> (Updated 2009-04-02 12:34:04)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia \
> section he/she can see "Audio Player - Amarok". But he requested it to be in other \
> way "Amarok - Audio Player". Hence as an initial step he asked me to add a check \
> box similar to "Switch tabs on hover". I had added a check box for this. I am a \
> newbie in KDE. Hence would like to know what next should I do to accomplish the \
> task. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp 947244 
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h 947244 
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp \
>                 947244 
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h 947244 
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 947244 
> 
> Diff: http://reviewboard.kde.org/r/441/diff
> 
> 
> Testing
> -------
> 
> I had compiled the above patch in my build directory. It compiled without any \
> errors.  
> 
> Thanks,
> 
> Sujith
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]