[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Patch regarding IRC discussion with Aron Seigo(its
From:       "Shantanu Tushar Jha" <jhahoneyk () gmail ! com>
Date:       2009-04-02 19:05:09
Message-ID: 20090402190509.27992.18981 () localhost
[Download RAW message or body]



> On 2009-04-02 11:55:26, Shantanu Tushar Jha wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp, lines \
> > 596-597 <http://reviewboard.kde.org/r/441/diff/5/?file=4680#file4680line596>
> > 
> > Maybe we can have a member variable m_showAppsByName which is used inside \
> > setupAllProgramsView() to set setNameDisplayOrder - 
> > if(m_showAppsByName) {
> > applicationModel->setNameDisplayOrder(ApplicationModel::NameBeforeDescription);
> > } else {        applicationModel->setNameDisplayOrder(ApplicationModel::NameAfterDescription);
> >  }
> > 
> > and Launcher::setShowAppsByName(bool showAppByName) just sets m_showAppsByName = \
> > showAppByName; 
> > and bool Launcher::showAppsByName() returns m_showAppsByName
> > 
> > 
> > this will be better than making applicationModel as a private member, am I right \
> > Aaron?
> 
> wrote:
> that won't work because the setting can be changed at runtime via the settings \
> dialog and after setupAllProgramsView is called, so you either need to re-create \
> the application model (rather wasteful) or else hang onto the pointer to it.

ohkay, got it :)


- Shantanu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/441/#review790
-----------------------------------------------------------


On 2009-04-02 09:33:32, Sujith  H wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/441/
> -----------------------------------------------------------
> 
> (Updated 2009-04-02 09:33:32)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia \
> section he/she can see "Audio Player - Amarok". But he requested it to be in other \
> way "Amarok - Audio Player". Hence as an initial step he asked me to add a check \
> box similar to "Switch tabs on hover". I had added a check box for this. I am a \
> newbie in KDE. Hence would like to know what next should I do to accomplish the \
> task. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp 947244 
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h 947244 
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp \
>                 947244 
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h 947244 
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 947244 
> 
> Diff: http://reviewboard.kde.org/r/441/diff
> 
> 
> Testing
> -------
> 
> I had compiled the above patch in my build directory. It compiled without any \
> errors.  
> 
> Thanks,
> 
> Sujith
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]