[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Add keyboard navigation to plasma applet Folder
From: "Shantanu Tushar Jha" <jhahoneyk () gmail ! com>
Date: 2009-04-02 15:55:50
Message-ID: 20090402155550.23790.68013 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/
-----------------------------------------------------------
(Updated 2009-04-02 08:55:49.469863)
Review request for Plasma.
Changes
-------
Provided support for keyboard navigation even if the user has made the view unsorted. \
Please try it out and report any issues that you may encounter. I've tried to adhere \
with the kdelibs coding style, hope its all right. :)
Summary
-------
This partly addresses the above bug, adding keyboard navigation and launch using \
Enter key. Please report if the code is too complex, I've tried my best to keep it to \
the point.
This addresses bug 187241.
https://bugs.kde.org/show_bug.cgi?id=187241
Diffs (updated)
-----
/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 947761
/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 947761
Diff: http://reviewboard.kde.org/r/368/diff
Testing
-------
Tested on latest SVN build. Navigation and launch work fine. The problem is with \
movement of the scrollbar with the keyboard focus, the scrollbar refuses to go to \
minimum value when m_scrollBar->setValue( m_scrollBar->minimum() ); is used. What am \
I doing wrong?
Thanks,
Shantanu
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic