[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Patch regarding IRC discussion with Aron Seigo(its
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2009-03-31 19:07:15
Message-ID: 20090331190715.455.31498 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/441/#review763
-----------------------------------------------------------



/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h
<http://reviewboard.kde.org/r/441/#comment455>

    this should be a private: member of the class. exposing variables directly isn't \
good, as it exposes the implementation details.



/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp
<http://reviewboard.kde.org/r/441/#comment452>

    if ((m_displayOrder == NameBeforeDescription) &&
        (!node->genericName.isEmpty())) {
        return node->genericName;
    } else {
        return node->appName;
    }



/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp
<http://reviewboard.kde.org/r/441/#comment454>

    this is an infinite loop :)
    
    it needs to call the corresponding method in the apps model. e.g.:
    
    if (showAppByName) {
        m_applicationModel->setNameDisplayOrder(NameBeforeDescription);
    } else {
        m_applicationModel->setNameDisplayOrder(NameAfterDescription);
    }
    
    this implies that you will need to make the ApplicationModel a member of the \
class as well so it can be accessed at this point.



/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp
<http://reviewboard.kde.org/r/441/#comment453>

    this is an infinite loop :)
    
    it needs to call the corresponding method in the apps model.


- Aaron


On 2009-03-31 11:24:45, Sujith  H wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/441/
> -----------------------------------------------------------
> 
> (Updated 2009-03-31 11:24:45)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia \
> section he/she can see "Audio Player - Amarok". But he requested it to be in other \
> way "Amarok - Audio Player". Hence as an initial step he asked me to add a check \
> box similar to "Switch tabs on hover". I had added a check box for this. I am a \
> newbie in KDE. Hence would like to know what next should I do to accomplish the \
> task. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h 947244 
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 947244 
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp \
>                 947244 
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h 947244 
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp 947244 
> 
> Diff: http://reviewboard.kde.org/r/441/diff
> 
> 
> Testing
> -------
> 
> I had compiled the above patch in my build directory. It compiled without any \
> errors.  
> 
> Thanks,
> 
> Sujith
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]