[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Clocks context menu to fast copying date and time
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2009-03-31 17:07:43
Message-ID: 200903311107.43544.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Tuesday 31 March 2009, Emdek wrote:
> >> If developers are interested and there is no objections I could try to
> >> create patch during this or next weekend. I'm already using this code
> >> in my
> >> applet for nearly half of year and it doesn't make any problems.
> >
> > sure thing :) send it to the list or post it on reviewboard.kde.org
> > (though if
> > it doesn't apply cleanly, reviewboard will have problems with it;
> > probably
> > best to just send it to the list in this case)
>
> I could try with reviewboard first, I could create patch using fresh
> checkout of lib to avoid problems.

ok.. and if that doesn't work out, then the list should work out ok.

> > yes, a default implementation would make sense here indeed. in fact, if
> > we
> > added a setTimeUpdateInterval(int ms) to ClockApplet, then it could be
> > replaced quite easily in most cases. it's really just the update
> > interval (and
> > how that's controlled/configured) that's the reason this is
> > reimplemented in
> > every clock.
>
> So I could create additional patch for this.
> It could also add four protected methods, for setting and getting values of
> interval and alignment. What do you think about this?

i think that would be great; centralizing more of the common code can only be 
a good thing :)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software


["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]