[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Patch regarding IRC discussion with Aron Seigo(its
From: "Sujith H" <sujith.h () gmail ! com>
Date: 2009-03-30 19:39:14
Message-ID: 20090330193914.17534.51250 () localhost
[Download RAW message or body]
> On 2009-03-27 17:28:45, Aaron Seigo wrote:
> > great! a few small issues to take care of; the next step is now to read the value \
> > when the applet is created. that should go into void \
> > Launcher::setApplet(Plasma::Applet *applet) in ui/launcher.cpp.
> > then modify ApplicationModel (in core/applicationmodel.cpp) to have the order set \
> > (e.g. setNameDisplayOrder(DisplayOrder) where DisplayOrder would be an enum \
> > (there's a FormatType enum in simpleapplet/simpleapplet.h that maybe could be \
> > moved somewhere in core/?), and then in ApplicationModel::data, return the name \
> > or generic name based on that setting.
> > that should complete the feature :)
>
> Sujith H wrote:
> I am stuck at ApplicationModel(in core/applicationmodel.cpp).
>
> Aaron Seigo wrote:
> create a method that is something like void setNameDisplayOrder(DisplayOrder) in \
> ApplicationModel. then modify ApplicationModel::data to return either the name or \
> the description depending on what the value was set to in setNameDisplayOrder. if \
> you can describe where you are stuck a bit more, perhaps i can offer a clearer \
> answer.
I wrote a method in core/applicationmodel.cpp
int ApplicationModel::setNameDisplayOrder(DisplayOrder displayorder)
{
displayorder = NameBeforeDescription;
return displayorder;
}
In the core/application.h I wrote:
class KICKOFF_EXPORT ApplicationModel : public KickoffAbstractModel
{
Q_OBJECT
Q_ENUMS(DisplayOrder)
public:
.
.
.
enum DisplayOrder {
NameAfterDescription,
NameBeforeDescription
};
.
.
.
.
virtual int setNameDisplayOrder(DisplayOrder);
}
But I am confused in the switch statement. What will be role(i.e, switch(role) in \
core/applicationmodel.cpp)? If I can know that I believe I can call \
setNameDisplayOrder(displayorder) there and return the value there.
I hope you got my point. If you need patch of my existing work, I can post that too.
- Sujith
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/441/#review654
-----------------------------------------------------------
On 2009-03-27 12:37:45, Sujith H wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/441/
> -----------------------------------------------------------
>
> (Updated 2009-03-27 12:37:45)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia \
> section he/she can see "Audio Player - Amarok". But he requested it to be in other \
> way "Amarok - Audio Player". Hence as an initial step he asked me to add a check \
> box similar to "Switch tabs on hover". I had added a check box for this. I am a \
> newbie in KDE. Hence would like to know what next should I do to accomplish the \
> task.
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp 945188
>
> Diff: http://reviewboard.kde.org/r/441/diff
>
>
> Testing
> -------
>
> I had compiled the above patch in my build directory. It compiled without any \
> errors.
>
> Thanks,
>
> Sujith
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic