[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: weather: adds a space between value and unit.
From:       Shawn Starr <shawn.starr () rogers ! com>
Date:       2009-03-30 1:34:35
Message-ID: 200903292134.37060.shawn.starr () rogers ! com
[Download RAW message or body]

On Sunday 29 March 2009 16:30:59 Aaron Seigo wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/465/#review701
> -----------------------------------------------------------
>
>
> diff isn't working, but assuming it's just adding a space in there, i think
> that makes sense.
>
> - Aaron
>
> On 2009-03-29 05:16:50, Davide Bettio wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/465/
> > -----------------------------------------------------------
> >
> > (Updated 2009-03-29 05:16:50)
> >
> >
> > Review request for Plasma.
> >
> >
> > Summary
> > -------
> >
> > Space between value and unit improves plasmoid usability. (100.20KPa ->
> > 100.20 KPa)
> >
> >
That space is ok to change.

Ship it!

> > Diffs
> > -----
> >
> >   KDE/kdeplasma-addons/applets/weather/weatherapplet.cpp 946357
> >
> > Diff: http://reviewboard.kde.org/r/465/diff
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Davide
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel


_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]