[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Plasma Notes bug and wish
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2009-03-27 22:11:11
Message-ID: 20090327221111.27896.28670 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/417/#review653
-----------------------------------------------------------


Small comment, otherwise looks OK. You can send the notes.svgz file to me to commit \
it.


trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp
<http://reviewboard.kde.org/r/417/#comment414>

    You can just write 
    
    m_useNoColor = cg.readEntry("useNoColor", true);
    
    instead of the tmp var and then casting it. It's a lot cleaner and KConfig \
actually understands most of the datatypes you ever want to save.


- Sebastian


On 2009-03-27 09:29:49, Maxime Hermouet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/417/
> -----------------------------------------------------------
> 
> (Updated 2009-03-27 09:29:49)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> I made changes that were whished by the refered bug
> I just need to send the patch to someone how can commit because I change a .svgz \
> file to add the transparency. 
> Thanks
> 
> 
> This addresses bug 179170.
> https://bugs.kde.org/show_bug.cgi?id=179170
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 945528 
> 
> Diff: http://reviewboard.kde.org/r/417/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Visuals of corrections
> http://reviewboard.kde.org/r/417/s/74/
> 
> 
> Thanks,
> 
> Maxime
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]