[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Add keyboard navigation to plasma applet Folder
From:       "Shantanu Tushar Jha" <jhahoneyk () gmail ! com>
Date:       2009-03-20 17:21:32
Message-ID: 20090320172132.30318.9627 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/
-----------------------------------------------------------

(Updated 2009-03-20 10:21:32.420468)


Review request for Plasma.


Changes
-------

Aaron, I couldn't believe I actually used a "this->" there, and it was so silly of me \
to forget the else. Thanks for pointing out this and the coding styles. The diff is \
updated accordingly, and the scrollbar behavior is fine now. :)


Summary
-------

This partly addresses the above bug, adding keyboard navigation and launch using \
Enter key. Please report if the code is too complex, I've tried my best to keep it to \
the point.


This addresses bug 187241.
    https://bugs.kde.org/show_bug.cgi?id=187241


Diffs (updated)
-----

  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 941694 
  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 941694 

Diff: http://reviewboard.kde.org/r/368/diff


Testing
-------

Tested on latest SVN build. Navigation and launch work fine. The problem is with \
movement of the scrollbar with the keyboard focus, the scrollbar refuses to go to \
minimum value when m_scrollBar->setValue( m_scrollBar->minimum() ); is used. What am \
I doing wrong?


Thanks,

Shantanu

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]