[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Addition to UI for Config page "Filter" in
From:       "Chani" <chanika () gmail ! com>
Date:       2009-03-08 19:29:17
Message-ID: 20090308192917.11697.50864 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/262/#review413
-----------------------------------------------------------


the patch itself looks fine, but... isn't there a way we can make the UI better so \
that there's no need for a tooltip at all?

- Chani


On 2009-03-08 09:58:46, Shantanu Tushar Jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/262/
> -----------------------------------------------------------
> 
> (Updated 2009-03-08 09:58:46)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This changes the UI for the configuration page "Filter" for the applet folderview. \
> As seen in the bug 186283, files are only displayed if they match both the pattern \
> and the MIME type. But there is no obvious indication to this behavior in the \
> interface. Added a label "Can't see files?" which has a tooltip explaining the \
> above behavior. (screenshot attached) Please review, and if found helpful, commit \
> it, as I don't have a svn account. 
> 
> This addresses bug 186283.
> https://bugs.kde.org/show_bug.cgi?id=186283
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/apps/plasma/applets/folderview/folderviewFilterConfig.ui 936718 
> 
> Diff: http://reviewboard.kde.org/r/262/diff
> 
> 
> Testing
> -------
> 
> On latest svn trunk build.
> 
> 
> Screenshots
> -----------
> 
> Filter config page
> http://reviewboard.kde.org/r/262/s/52/
> 
> 
> Thanks,
> 
> Shantanu
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]