[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Comic applet using Plasma::Widgets
From:       "Matthias Fuchs" <mat69 () gmx ! net>
Date:       2009-03-06 17:11:09
Message-ID: 20090306171109.19220.33259 () localhost
[Download RAW message or body]



> On 2009-03-02 11:46:24, Aaron Seigo wrote:
> > looks good...
> > 
> > on a semi-related note, i really think offering a configuration option for the \
> > style of arrows is a mistake. the arrows on hover is much more in the spirit of \
> > Plasma and the graphics for them look so much better. it offer the maximal space \
> > for content as well. i really see no measurable benefit to offering the \
> > configuration option other than "because we can". meanwhile, there's more code to \
> > maintain and more buttons and levers for users to manage. just my 0.02

Sorry, I missed your comment.

Initially I also thought about removing that configuration option, but then I thought \
about touch screens. In touch screens the hovering icons would most likely (have no \
way to test that) be a pain to use.

Additionally for reading a comic strip -- let us say starting with strip #10 to #30 \
-- I felt that the hovering icons are less comfortable to use.

Though I have to agree that the current configuration situation is not the best and \
with adding tabs it will get "worse" --> meaning more options. I'm not sure how to \
change that and I think that adding two config-pages as I did is only the first step.


> On 2009-03-02 11:46:24, Aaron Seigo wrote:
> > /trunk/KDE/kdeplasma-addons/applets/comic/arrowwidget.h, line 41
> > <http://reviewboard.kde.org/r/145/diff/5/?file=1306#file1306line41>
> > 
> > how about Plasma::Direction? it already exists :)

Oh, did not know that, thanks. :)

Really funny somehow. :D


- Matthias


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/145/#review328
-----------------------------------------------------------


On 2009-02-28 07:59:03, Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/145/
> -----------------------------------------------------------
> 
> (Updated 2009-02-28 07:59:03)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> I converted the comic applet to use Plasma::Widgets and basically everything works \
> nice. 
> I have some questions though:
> 
> * Is there a way to avoid recreating the layout (ComicApplet::createLayout() in \
>                 this case )?
> * Is there a way to add SpacerItems, so that mLabelId would be on the left of \
> bottomLayout and only use as much space as needed, while mLabelUrl would be on the \
> right and only use as much space needed as well? 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdeplasma-addons/applets/comic/CMakeLists.txt 930543 
> /trunk/KDE/kdeplasma-addons/applets/comic/arrowwidget.h PRE-CREATION 
> /trunk/KDE/kdeplasma-addons/applets/comic/arrowwidget.cpp PRE-CREATION 
> /trunk/KDE/kdeplasma-addons/applets/comic/comic.h 931593 
> /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp 931593 
> /trunk/KDE/kdeplasma-addons/applets/comic/imagewidget.h PRE-CREATION 
> /trunk/KDE/kdeplasma-addons/applets/comic/imagewidget.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/145/diff
> 
> 
> Testing
> -------
> 
> Plasma::Labels do not adapt to the size of the text here.
> 
> 
> Screenshots
> -----------
> 
> 
> http://reviewboard.kde.org/r/145/s/42/
> 
> 
> Thanks,
> 
> Matthias
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]