[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: qwidget for monitor previews
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2009-03-02 19:53:25
Message-ID: 20090302195325.27454.27410 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/187/#review329
-----------------------------------------------------------

Ship it!


i wish we could put this in libkdeui, tbh, but it makes the most sense in libplasma \
indeed (esp due to integration with Plasma::Wallpaper).

i don't like the name, though. Plasma::ScreenPreviewWidget is probably better imho. \
Plasma::Util::ScreenWidget is a bit odd (why is it a utility? none of the other \
widgets are) and "ScreenWidget" to me says "this is a widget you use when you want to \
cover the whole screen" or something along those lines. 

otherwise.. huzzah!

- Aaron


On 2009-02-25 13:13:02, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/187/
> -----------------------------------------------------------
> 
> (Updated 2009-02-25 13:13:02)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> it's a qwidget that rapresent the monitor for wallpaper previews, i'm putting it \
> public because it's used also by the screensaver kcm and in two places in the login \
> manager, and the picture frame. but i'm also not very happy adding stuff in the \
> plasma namespace, so here the Plasma::Util namespace (sadly some stuff in Plasma:: \
> would make more sense here but it's too late, oh, well...) 
> will add apidocs :)
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/plasma/CMakeLists.txt 930878 
> /trunk/KDE/kdelibs/plasma/util/screenwidget.h PRE-CREATION 
> /trunk/KDE/kdelibs/plasma/util/screenwidget.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/187/diff
> 
> 
> Testing
> -------
> 
> wallpapers settings and screensaver for now
> 
> 
> Screenshots
> -----------
> 
> 
> http://reviewboard.kde.org/r/187/s/33/
> 
> 
> Thanks,
> 
> Marco
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]