[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: borders of Plasma::Dialog dependent on screen
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2009-03-01 20:42:26
Message-ID: 20090301204226.31467.26195 () localhost
[Download RAW message or body]



> On 2009-03-01 12:03:38, Chani wrote:
> > /trunk/KDE/kdelibs/plasma/dialog.cpp, line 107
> > <http://reviewboard.kde.org/r/206/diff/2/?file=1500#file1500line107>
> > 
> > why are you setting left and right to 0 in every case but default?

because when there is an extender the margins are managed by extenderitems, it's the \
way the stacked look for  notifications is achieved. i also tought about using this \
approach also for extenders but it wuld mean iterate to all the extender items to \
change their borders, not really good :/


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/206/#review314
-----------------------------------------------------------


On 2009-03-01 12:11:21, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/206/
> -----------------------------------------------------------
> 
> (Updated 2009-03-01 12:11:21)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this makes all dialogs to not have the bottom border, not just the extender based \
> ones. also vertical borders are deactivated, this solves also the fitts law problem \
> of kickoff 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/plasma/dialog.h 932222 
> /trunk/KDE/kdelibs/plasma/dialog.cpp 932222 
> 
> Diff: http://reviewboard.kde.org/r/206/diff
> 
> 
> Testing
> -------
> 
> tested with panels at four edges, extenders handling is leaved as it was (changed a \
> bit the code to integrate with the other part, same algorithm) 
> 
> Screenshots
> -----------
> 
> 
> http://reviewboard.kde.org/r/206/s/43/
> 
> 
> Thanks,
> 
> Marco
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]