[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Let PopupApplet show BusyWidget in popup
From: "Artur de Souza \(MoRpHeUz\)" <morpheuz () gmail ! com>
Date: 2009-02-28 22:52:25
Message-ID: 20090228225225.31826.86797 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/177/
-----------------------------------------------------------
(Updated 2009-02-28 14:52:24.624693)
Review request for Plasma and Aaron Seigo.
Changes
-------
Fixed the memory leak. Put inside the d pointer. richmoore and notmart reviewed it.
Summary
-------
Right now, PopupApplet can't show BusyWidget because it uses the applet's \
boundingRect. To make it work inside the popup of PopupApplet, we need to change some \
code inside Plasma::Applet to test if we have popup and if this is true, if we should \
use widget() or graphicsWidget().
Diffs (updated)
-----
/trunk/KDE/kdelibs/plasma/applet.cpp 933044
/trunk/KDE/kdelibs/plasma/private/applet_p.h 933044
Diff: http://reviewboard.kde.org/r/177/diff
Testing
-------
Screenshots
-----------
busywidget
http://reviewboard.kde.org/r/177/s/30/
Thanks,
Artur
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic